netdev - Re: [PATCH] NET : convert ip_rt_acct to per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071116.011243.48184084.davem@davemloft.net>
Date:	Fri, 16 Nov 2007 01:12:43 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] NET : convert ip_rt_acct to per_cpu variables

From: Eric Dumazet <dada1@...mosbay.com>
Date: Fri, 16 Nov 2007 09:59:03 +0100

> [PATCH] NET : NET_CLS_ROUTE : convert ip_rt_acct to per_cpu variables
> 
> ip_rt_acct needs 4096 bytes per cpu to perform some accounting.
> It is actually allocated as a single huge array [4096*NR_CPUS]
> (rounded up to a power of two)
> 
> Converting it to a per cpu variable is wanted to :
>  - Save space on machines were num_possible_cpus() < NR_CPUS
>  - Better NUMA placement (each cpu gets memory on its node)
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

This is better in one sense but worse in another.

At least the previous code dynamically allocated the thing,
now at least one copy is taking up core kernel text image
space.

I think it's an alloc_percpu() candidate, what do you think?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html