netdev - Re: [PATCH, take2] netfilter : struct xt_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <474291B7.6060602@trash.net>
Date:	Tue, 20 Nov 2007 08:50:15 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	Simon Horman <horms@...ge.net.au>, dada1@...mosbay.com,
	davem@...emloft.net, netdev@...r.kernel.org,
	netfilter-devel@...ts.netfilter.org
Subject: Re: [PATCH, take2] netfilter : struct xt_table_info diet

Herbert Xu wrote:
> Simon Horman <horms@...ge.net.au> wrote:
>   
>> @@ -269,9 +269,12 @@ struct xt_table_info
>>        unsigned int underflow[NF_INET_NUMHOOKS];
>>
>>        /* ipt_entry tables: one per CPU */
>> -       char *entries[NR_CPUS];
>> +       /* Note : this field MUST be the last one, see XT_TABLE_INFO_SZ */
>> +       char *entries[1];
>>     
>
> Just do
>
> 	char *entries[];
>
> Not only is it ISO C99, but the compiler will die if it's not at
> the end.
>
> Actually I haven't read the rest of the patch, so scratch this
> comment if you really need to have one entry there for some reason :)
>   

I thought this too, but its needed for the bootstrap tables, which are
declared on the stack :)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html