netdev - Re: [PATCH, take2] netfilter : struct xt_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1IuN87-0003r5-00@gondolin.me.apana.org.au>
Date:	Tue, 20 Nov 2007 15:02:43 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	horms@...ge.net.au (Simon Horman)
Cc:	dada1@...mosbay.com, kaber@...sh.net, davem@...emloft.net,
	netdev@...r.kernel.org, netfilter-devel@...ts.netfilter.org
Subject: Re: [PATCH, take2] netfilter : struct xt_table_info diet

Simon Horman <horms@...ge.net.au> wrote:
>
> @@ -269,9 +269,12 @@ struct xt_table_info
>        unsigned int underflow[NF_INET_NUMHOOKS];
> 
>        /* ipt_entry tables: one per CPU */
> -       char *entries[NR_CPUS];
> +       /* Note : this field MUST be the last one, see XT_TABLE_INFO_SZ */
> +       char *entries[1];

Just do

	char *entries[];

Not only is it ISO C99, but the compiler will die if it's not at
the end.

Actually I haven't read the rest of the patch, so scratch this
comment if you really need to have one entry there for some reason :)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html