netdev - Re: [PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071120070601.GE10490@verge.net.au>
Date:	Tue, 20 Nov 2007 16:06:03 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Joe Perches <joe@...ches.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	"Pekka Savola (ipv6)" <pekkas@...core.fi>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	James Morris <jmorris@...ei.org>,
	Patrick McHardy <kaber@...eworks.de>
Subject: Re: [PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

On Mon, Nov 19, 2007 at 10:40:12PM -0800, Joe Perches wrote:
> Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET
> macros to inline functions ipv4_is_<type>(__be32 addr)
> 
> Adds some type safety and arguably some readability
> 
> No change in compiled image size
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

I can understand the motivation for moving the functionality into
inline functions in order to get some type safety. But what is
the motivation for changing all the macro calls to function calls,
when you have set up the marcos to call the appropriate functions?
Surely if you want to do that you should just ditch the marcos all
together. Perhaps I am missing a patch?

Also, as the function names are longer than the macro name
you are creating lines that are > 80 columns wide that used
not to be in that state. For my eyes that reduced readability
(substantially).

-- 
Horms

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html