| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20071119200739.60bfb1f5@freepuppy.rosehill> Date: Mon, 19 Nov 2007 20:07:39 -0800 From: Stephen Hemminger <shemminger@...ux-foundation.org> To: David Miller <davem@...emloft.net> Cc: satyam@...radead.org, netdev@...r.kernel.org Subject: Re: [PATCH 06/11] netpoll: remove dev_name for npinfo On Mon, 19 Nov 2007 19:47:50 -0800 (PST) David Miller <davem@...emloft.net> wrote: > From: Stephen Hemminger <shemminger@...ux-foundation.org> > Date: Sat, 03 Nov 2007 11:43:20 -0700 > > > The device name was only in npinfo for netconsole target > > configuration, so move it to netconsole. Netconsole only > > needs the value during config, so no need to do all > > the device name tracking etc.. > > > > Make functions for common code for instantiation and > > start up. > > > > Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org> > > Sigh... > > return -EUNTESTED; > > In netpoll_parse_options() np->dev isn't setup yet, so if you had > tested this patch you would have gotten an immediate OOPS. Sorry, I missed the boot up case, I was testing with modprobe and dyanmic reconfig stuff. Places that store the name (and then get confused by renames) are one of the lingering mis-features of the whole network device infrastructure. -- Stephen Hemminger <shemminger@...ux-foundation.org> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists