netdev - Re: [PATCH 09/11] netpoll: ethernet devices only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071119201459.03d8f143@freepuppy.rosehill>
Date:	Mon, 19 Nov 2007 20:14:59 -0800
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	David Miller <davem@...emloft.net>
Cc:	satyam@...radead.org, netdev@...r.kernel.org
Subject: Re: [PATCH 09/11] netpoll: ethernet devices only

On Mon, 19 Nov 2007 19:55:15 -0800 (PST)
David Miller <davem@...emloft.net> wrote:

> From: Stephen Hemminger <shemminger@...ux-foundation.org>
> Date: Sat, 03 Nov 2007 11:43:23 -0700
> 
> > Netpoll only works on Ethernet devices, so check during setup
> > rather than just failing silently later.
> > 
> > Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org>
> > 
> > --- a/net/core/netpoll.c	2007-11-03 11:05:33.000000000 -0700
> > +++ b/net/core/netpoll.c	2007-11-03 11:08:23.000000000 -0700
> > @@ -653,6 +653,12 @@ int netpoll_setup(struct netpoll *np, st
> >  	unsigned long flags;
> >  	int err;
> >  
> > +	if (ndev->type != ARPHRD_ETHER) {
> > +		printk(KERN_ERR "netpoll: %s is not an ethernet device\n",
> > +		       ndev->name);
> > +		return -EINVAL;
> > +	}
> > +
> >  	np->dev = ndev;
> 
> This patch depends upon the broken np->dev_name one, and I also would
> rather fix the limitations in netpoll.

Existing netpoll depends on Ethernet and IPV4. Doing the right thing
might be hard because it would mean going through more inside irq.

Probably the right thing to do would be to build a header through the
normal path and cache it some how.

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html