netdev - Re: [PATCH] amd8111e: don't call napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <474795F0.1040600@pobox.com>
Date:	Fri, 23 Nov 2007 22:09:36 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Jiri Bohac <jbohac@...e.cz>
CC:	Stephen Hemminger <shemminger@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] amd8111e: don't call napi_enable if configured w/o NAPI

Jiri Bohac wrote:
> The amd8111e network driver was broken by 
> bea3348eef27e6044b6161fd04c3152215f96411, which makes the driver
> call napi_enable() and napi_disable() even if the driver had been 
> configured without CONFIG_AMD8111E_NAPI, and thus
> netif_napi_add() had not been called on initialization.
> This triggers a BUG in napi_enable().
> 
> This patch fixes the problem. Please apply.
> 
> Signed-off-by: Jiri Bohac <jbohac@...e.cz>
> 

applied #upstream-fixes

would you consider creating and testing a patch that removed the 
non-NAPI path completely?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html