lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <474795FA.5050701@garzik.org> Date: Fri, 23 Nov 2007 22:09:46 -0500 From: Jeff Garzik <jeff@...zik.org> To: Peter Korsgaard <jacmet@...site.dk> CC: netdev@...r.kernel.org, super.firetwister@...glemail.com Subject: Re: [PATCH] smc911x: Fix undefined CONFIG_ symbol warning Peter Korsgaard wrote: > elif defined(CONFIG_*) should be used instead of elif CONFIG_* > so GCC doesn't give warnings about undefined symbols when the config > option is disabled. > --- > drivers/net/smc911x.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/smc911x.h b/drivers/net/smc911x.h > index 16a0edc..d04e4fa 100644 > --- a/drivers/net/smc911x.h > +++ b/drivers/net/smc911x.h > @@ -37,7 +37,7 @@ > #define SMC_USE_16BIT 0 > #define SMC_USE_32BIT 1 > #define SMC_IRQ_SENSE IRQF_TRIGGER_FALLING > -#elif CONFIG_SH_MAGIC_PANEL_R2 > +#elif defined(CONFIG_SH_MAGIC_PANEL_R2) > #define SMC_USE_SH_DMA 0 > #define SMC_USE_16BIT 0 applied all three to #upstream-fixes - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists