netdev - Re: [PATCH] [RFC] New driver "sfc" for Solarstorm SFC4000 controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1196232474.31590.75.camel@localhost>
Date:	Tue, 27 Nov 2007 22:47:54 -0800
From:	Joe Perches <joe@...ches.com>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>,
	Andy Whitcroft <apw@...dowen.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Joel Schopp <jschopp@...tin.ibm.com>
Cc:	Ben Hutchings <bhutchings@...arflare.com>, netdev@...r.kernel.org,
	linux-net-drivers@...arflare.com
Subject: Re: [PATCH] [RFC] New driver "sfc" for Solarstorm SFC4000
	controller

On Tue, 2007-11-27 at 22:09 -0800, Stephen Hemminger wrote:
> ERROR: Macros with multiple statements should be enclosed in a do - while loop
> #21846: FILE: drivers/net/sfc/net_driver.h:1096:
> +	for (_channel = &_efx->channel[0];				\
> +	     _channel < &_efx->channel[EFX_MAX_CHANNELS];		\
> +	     _channel++)						\

This should probably be a WARNING in checkpatch.
Any list_for_each style macro fails this test.


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html