netdev - Re: [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071128074426.GA30468@infradead.org>
Date:	Wed, 28 Nov 2007 07:44:26 +0000
From:	Christoph Hellwig <hch@...radead.org>
To:	"Love, Robert W" <robert.w.love@...el.com>
Cc:	linux-scsi@...r.kernel.org,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	devel@...n-fcoe.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Rob Love <robert.w.love@...ux.intel.com>,
	"Leech, Christopher" <christopher.leech@...el.com>,
	"Zou, Yi" <yi.zou@...el.com>, "Dev, Vasu" <vasu.dev@...el.com>,
	james.bottomley@...senpartnership.com, davem@...emloft.net,
	jeff@...zik.org, "Kok, Auke-jan H" <auke-jan.h.kok@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"Van De Ven, Arjan" <arjan.van.de.ven@...el.com>,
	Mike Christie <michaelc@...wisc.edu>
Subject: Re: [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project

I just did a very quick glance over the tree.  Some extremly highlevel
comments to start with before actually starting the source review:


 - why do you need your own libcrc?  lib/crc32.c has a crc32_le
 - libsa should go.  Much of it is just wrappers of kernel functions
   that should be used directly.  Other like that hash, even or state
   helpers might either be opencoded in the caller or made completely
   generic in lib/.  Probably the former but we'll have to see.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html