netdev - Re: [PATCH 3/3] [UDP6]: Counter increment on BH mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071130111949.GB28277@gerrit.erg.abdn.ac.uk>
Date:	Fri, 30 Nov 2007 11:19:49 +0000
From:	Gerrit Renker <gerrit@....abdn.ac.uk>
To:	Wang Chen <wangchen@...fujitsu.com>
Cc:	herbert@...dor.apana.org.au, davem@...emloft.net,
	andi@...stfloor.org, netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] [UDP6]: Counter increment on BH mode

Quoting Wang Chen:
| (This patch base on "PATCH 2/3".)
| 
| UDP_MIB_INERRORS increment is in different way for IPv4
| and IPv6. For the consistence, change UDP6_INC_STATS_USER
| to UDP6_INC_STATS_BH.
| 
| Signed-off-by: Wang Chen <wangchen@...fujitsu.com>
| ---
|  udp.c |    2 +-
|  1 files changed, 1 insertion(+), 1 deletion(-)
| 
| --- linux-2.6.24.rc3.org/net/ipv6/udp.c	2007-11-30 10:38:36.000000000 +0800
| +++ linux-2.6.24.rc3/net/ipv6/udp.c	2007-11-30 10:39:01.000000000 +0800
| @@ -207,7 +207,7 @@ out:
|  	return err;
|  
|  csum_copy_err:
| -	UDP6_INC_STATS_USER(UDP_MIB_INERRORS, is_udplite);
| +	UDP6_INC_STATS_BH(UDP_MIB_INERRORS, is_udplite);
|  	skb_kill_datagram(sk, skb, flags);
|  
|  	if (flags & MSG_DONTWAIT)
| 
Is it not the other way round ?? :- 

	struct proto udp{,v6}_prot = {
		// ...
		.recvmsg           = udp{,v6}_recvmsg,
	};

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html