netdev - Re: [PATCH 3/3] [UDP6]: Counter increment on BH mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071201015438.GC26895@gondor.apana.org.au>
Date:	Sat, 1 Dec 2007 12:54:38 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Gerrit Renker <gerrit@....abdn.ac.uk>
Cc:	Wang Chen <wangchen@...fujitsu.com>, davem@...emloft.net,
	andi@...stfloor.org, netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] [UDP6]: Counter increment on BH mode

On Fri, Nov 30, 2007 at 11:19:49AM +0000, Gerrit Renker wrote:
>
> |  csum_copy_err:
> | -	UDP6_INC_STATS_USER(UDP_MIB_INERRORS, is_udplite);
> | +	UDP6_INC_STATS_BH(UDP_MIB_INERRORS, is_udplite);
> |  	skb_kill_datagram(sk, skb, flags);
> |  
> |  	if (flags & MSG_DONTWAIT)
> | 
> Is it not the other way round ?? :- 

I agree.  Wang Chen, please change this and other appropriate
BH calls to USER.  Basically recvmsg should always be USER while
rcv is BH.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html