netdev - Re: [PATCH] sky2: RX lockup fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071205164058.157275a9@shemminger-laptop>
Date:	Wed, 5 Dec 2007 16:40:58 -0500
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Peter Tyser <ptyser@...-inc.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] sky2: RX lockup fix

On Wed, 05 Dec 2007 12:51:03 -0600
Peter Tyser <ptyser@...-inc.com> wrote:

> Hello,
> I'm using a Marvell 88E8062 on a custom PPC64 blade and ran into RX
> lockups while validating the sky2 driver.  The receive MAC FIFO would
> become stuck during testing with high traffic.  One port of the 88E8062
> would lockup, while the other port remained functional.  Re-inserting
> the sky2 module would not fix the problem - only a power cycle would.
> 
> I looked over Marvell's most recent sk98lin driver and it looks like
> they had a "workaround" for the Yukon XL that the sky2 doesn't have yet.
> The sk98lin driver disables the RX MAC FIFO flush feature for all
> revisions of the Yukon XL.
> 
> According to skgeinit.c of the sk98lin driver, "Flushing must be enabled
> (needed for ASF see dev. #4.29), but the flushing mask should be
> disabled (see dev. #4.115)".  Nice.   I implemented this same change in
> the sky2 driver and verified that the RX lockup I was seeing was
> resolved.
> 


Without the flush, does flow control still work? My concern is that
integrating this would cause pause packets (and over/under length packets)
to not be handled correctly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html