netdev - Re: Pull request for 'ipg' branch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071205215157.GA3665@electric-eye.fr.zoreil.com>
Date:	Wed, 5 Dec 2007 22:51:57 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Joe Perches <joe@...ches.com>
Cc:	jeff@...zik.org, Pekka Enberg <penberg@...helsinki.fi>,
	Sorbica Shieh <sorbica@...lus.com.tw>,
	Jesse Huang <jesse@...lus.com.tw>,
	Andrew Morton <akpm@...ux-foundation.org>,
	netdev@...r.kernel.org
Subject: Re: Pull request for 'ipg' branch

Joe Perches <joe@...ches.com> :
[...]
> > -	if ((sp->LED_Mode & 0x01) == 1)
> > +	if ((sp->led_mode & 0x01) == 1)
> 
> I think the use of hex and decimal constants is odd.
> I think "if (sp->led_mode & 0x01)" is better.

Yes, the whole context of this code in the driver is a bit special.

[...]
> >  /* Assign IPG_APPEND_FCS_ON_TX > 0 for auto FCS append on TX. */
> > -#define         IPG_APPEND_FCS_ON_TX         TRUE
> > +#define         IPG_APPEND_FCS_ON_TX         1
> 
> Why not true and false?

No objection. Both can be used.

[...]
> > @@ -753,8 +732,7 @@ enum ipg_regs {
> >   * Miscellaneous macros.
> >   */
> >  
> > -/* Marco for printing debug statements.
> > -#  define IPG_DDEBUG_MSG(args...) printk(KERN_DEBUG "IPG: " ## args) */
> > +/* Marco for printing debug statements. */
> 
> Macros

I actively ignored it. It was not easy. :o)

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html