lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 09 Dec 2007 10:13:48 +0800
From:	Herbert Xu <>
To: (Paul Moore)
Subject: Re: IPsec replay sequence number overflow behavior? (RFC4303 section 3.3.3)

Paul Moore <> wrote:
> If it is a bug, I think the basic fix should be pretty simple, changing the 
> above xfrm_output() code to the following:
>   if (x->type->flags & XFRM_TYPE_REPLAY_PROT) {
>           XFRM_SKB_CB(skb)->seq = ++x->replay.oseq;
> +          if (x->replay.oseq == 0)
> +                  goto error;

Yes we need this check.

However please add an unlikely around it since it's a 1-in-4
billion event :)

Visit Openswan at
Email: Herbert Xu ~{PmV>HI~} <>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists