[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20071211123705.844aac24.akpm@linux-foundation.org>
Date: Tue, 11 Dec 2007 12:37:05 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Martin Bligh" <mbligh@...gle.com>
Cc: linux-kernel@...r.kernel.org, "Andy Whitcroft" <apw@...dowen.org>,
netdev@...r.kernel.org, Auke Kok <auke-jan.h.kok@...el.com>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...e.hu>
Subject: Re: 2.6.24-rc4-mm1
On Tue, 11 Dec 2007 08:13:52 -0800 "Martin Bligh" <mbligh@...gle.com> wrote:
> >
> >
> > - Lots of device IDs have been removed from the e1000 driver and moved
> > over
> > to e1000e. So if your e1000 stops working, you forgot to set
> > CONFIG_E1000E.
> >
> >
> Wouldn't it make sense to just default this to on if E1000 was on, rather
> than screwing
> everybody for no good reason (plus breaking all the automated testing, etc
> etc)?
> Much though I love random refactoring, it is fairly painful to just keep
> changing the
> names of things.
(cc netdev and Auke)
Yes, that would be very sensible. CONFIG_E1000E should default to whatever
CONFIG_E1000 was set to.
>
> I can't see this compile failure posted anywhere:
> http://test.kernel.org/results/IBM/126049/build/debug/stderr
>
> arch/x86/vdso/vdso32/sigreturn.S: Assembler messages:
> arch/x86/vdso/vdso32/sigreturn.S:23: Error: suffix or operands invalid for `pop'
> arch/x86/vdso/vdso32/syscall.S:25: Error: suffix or operands invalid for `pop'
> make[1]: *** [arch/x86/vdso/vdso32/syscall.o] Error 1
> make: *** [arch/x86/vdso] Error 2
(cc Ingo and Thomas)
>
> Nor this one:
> http://test.kernel.org/results/IBM/126096/build/debug/stderr
>
> drivers/char/hvcs.c: In function ‘hvcs_open’:
> drivers/char/hvcs.c:1180: error: wrong type argument to unary exclamation mark
>
(cc Greg)
Caused by gregkh-driver-kobject-convert-hvcs-to-use-kref-not-kobject.patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists