netdev - Re: DM9000_IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Dec 2007 21:31:03 +0100
From:	"Remy Bohmer" <linux@...mer.net>
To:	"Daniel Mack" <daniel@...aq.de>
Cc:	netdev@...r.kernel.org
Subject: Re: DM9000_IRQ_FLAGS

Hello Daniel,

This controller is also used on many other boards, like the e.g. Atmel
AT91sam9261-ek board. On that board on both the rising _and_ falling
edge an interrupt is generated.

I can test tomorrow if this patch leaves this board in tact, but
should the board-specific code not add this flag if it is required ?
By modifying this driver you will interfere the behavior of other
boards, and I do not know if there any level triggered types used.


Kind Regards,

Remy Bohmer


2007/12/11, Daniel Mack <daniel@...aq.de>:
> Hi,
>
> on Toradex' Colibri, a PXA270 based board with a DM9000 ethernet
> controller, this driver won't work due to unsuitable DM9000_IRQ_FLAGS.
> If I understood the code behind request_irq() correctly, it's not
> recommended to register an IRQ without any of the IRQT_* flags set.
>
> Is there any concerns about applying the patch below?
>
> Best regards,
> Daniel
>
> diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
> index 3286d2a..6a20a54 100644
> --- a/drivers/net/dm9000.c
> +++ b/drivers/net/dm9000.c
> @@ -66,6 +66,7 @@
>  #include <linux/dm9000.h>
>  #include <linux/delay.h>
>  #include <linux/platform_device.h>
> +#include <linux/irq.h>
>
>  #include <asm/delay.h>
>  #include <asm/irq.h>
> @@ -113,7 +114,7 @@
>  #define writesl        outsl
>  #define DM9000_IRQ_FLAGS       (IRQF_SHARED | IRQF_TRIGGER_HIGH)
>  #else
> -#define DM9000_IRQ_FLAGS       IRQF_SHARED
> +#define DM9000_IRQ_FLAGS       (IRQF_SHARED | IRQT_RISING)
>  #endif
>
>  /*
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html