lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 13 Dec 2007 09:35:45 -0800
From:	Stephen Hemminger <>
To:	kristjan <>,
	"David S. Miller" <>,
	Jeff Garzik <>
Subject: [PATCH 1/2] tulip: napi full quantum bug

This should fix the kernel warn/oops reported while routing.

The tulip driver has a fencepost bug with new NAPI in 2.6.24
It has an off by one bug if a full quantum is reached.

Signed-off-by: Stephen Hemminger <>

--- a/drivers/net/tulip/interrupt.c	2007-12-13 09:20:27.000000000 -0800
+++ b/drivers/net/tulip/interrupt.c	2007-12-13 09:23:34.000000000 -0800
@@ -151,7 +151,8 @@ int tulip_poll(struct napi_struct *napi,
                        if (tulip_debug > 5)
                                printk(KERN_DEBUG "%s: In tulip_rx(), entry %d %8.8x.\n",
                                       dev->name, entry, status);
-		       if (work_done++ >= budget)
+		       if (++work_done >= budget)
                                goto not_done;
                        if ((status & 0x38008300) != 0x0300) {
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists