[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20071216.134059.239467197.davem@davemloft.net>
Date: Sun, 16 Dec 2007 13:40:59 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: shemminger@...ux-foundation.org
Cc: kristjan.ugrin@...il.com, jgarzik@...ox.com, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] tulip: napi full quantum bug
From: Stephen Hemminger <shemminger@...ux-foundation.org>
Date: Thu, 13 Dec 2007 09:35:45 -0800
> This should fix the kernel warn/oops reported while routing.
>
> The tulip driver has a fencepost bug with new NAPI in 2.6.24
> It has an off by one bug if a full quantum is reached.
>
> Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org>
Acked-by: David S. Miller <davem@...emloft.net>
Jeff, please apply if you haven't already.
> --- a/drivers/net/tulip/interrupt.c 2007-12-13 09:20:27.000000000 -0800
> +++ b/drivers/net/tulip/interrupt.c 2007-12-13 09:23:34.000000000 -0800
> @@ -151,7 +151,8 @@ int tulip_poll(struct napi_struct *napi,
> if (tulip_debug > 5)
> printk(KERN_DEBUG "%s: In tulip_rx(), entry %d %8.8x.\n",
> dev->name, entry, status);
> - if (work_done++ >= budget)
> +
> + if (++work_done >= budget)
> goto not_done;
>
> if ((status & 0x38008300) != 0x0300) {
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists