netdev - Re: Inline local_bh_disable when TRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071219113152.GD20736@elte.hu>
Date:	Wed, 19 Dec 2007 12:31:52 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: Inline local_bh_disable when TRACE_IRQFLAGS


* Herbert Xu <herbert@...dor.apana.org.au> wrote:

> Hi Ingo:
> 
> I noticed that local_bh_disable is now always out-of-line.  The change 
> was made when TRACE_IRQFLAGS was added.  However, with TRACE_IRQFLAGS 
> off, local_bh_disable does exactly the same work as before.  In 
> particular, it does pretty much the same as what preempt_disable does 
> and the latter is always inline.
> 
> So I'm wondering if it would be reasonable to make it out-of-line when 
> TRACE_IRQFLAGS is off.  This may make a difference because the 
> networking stack is a frequent user of local_bh_disable and 
> local_bh_enable.

do you mean to make it inline again?

(btw., generally i think local_bh_disable() is a poor API because it is 
opaque about the data structure dependency that it governs. Explicit 
exclusion rules generally work better.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html