netdev - Re: [PATCH 1/3] XFRM: Assorted IPsec fixups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071220.204943.215363882.davem@davemloft.net>
Date:	Thu, 20 Dec 2007 20:49:43 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jmorris@...ei.org
Cc:	paul.moore@...com, netdev@...r.kernel.org, linux-audit@...hat.com,
	latten@...tin.ibm.com
Subject: Re: [PATCH 1/3] XFRM: Assorted IPsec fixups

From: James Morris <jmorris@...ei.org>
Date: Fri, 21 Dec 2007 09:25:38 +1100 (EST)

> On Thu, 20 Dec 2007, Paul Moore wrote:
> 
> > This patch fixes a number of small but potentially troublesome things in the
> > XFRM/IPsec code:
> > 
> >  * Use the 'audit_enabled' variable already in include/linux/audit.h
> >    Removed the need for extern declarations local to each XFRM audit fuction
> > 
> >  * Convert 'sid' to 'secid' everywhere we can
> >    The 'sid' name is specific to SELinux, 'secid' is the common naming
> >    convention used by the kernel when refering to tokenized LSM labels,
> >    unfortunately we have to leave 'ctx_sid' in 'struct xfrm_sec_ctx' otherwise
> >    we risk breaking userspace
> > 
> >  * Convert address display to use standard NIP* macros
> >    Similar to what was recently done with the SPD audit code, this also also
> >    includes the removal of some unnecessary memcpy() calls
> > 
> >  * Move common code to xfrm_audit_common_stateinfo()
> >    Code consolidation from the "less is more" book on software development
> > 
> >  * Proper spacing around commas in function arguments
> >    Minor style tweak since I was already touching the code
> > 
> > Signed-off-by: Paul Moore <paul.moore@...com>
> 
> Acked-by: James Morris <jmorris@...ei.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html