[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20071224.220527.254578945.davem@davemloft.net>
Date: Mon, 24 Dec 2007 22:05:27 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: stephen.hemminger@...tta.com
Cc: vgusev@...nvz.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: santize headers for iproute2
From: Stephen Hemminger <stephen.hemminger@...tta.com>
Date: Fri, 21 Dec 2007 09:43:36 -0800
> iproute2 source uses headers that result from "make headers_install".
> The header files net/tcp_states.h and net/veth.h are both being used
> but are not processed.
>
> Signed-off-by: Stephen Hemminger <stephen.hemminger@...tta.com>
The convention is to place user visible interfaces in header
files under include/linux/ and purely kernel internal bits
in header files under include/net/
Therefore exporting net/*.h headers is not right.
net/veth.h only defines user visible interfaces, so it
belongs under include/linux and added to include/linux/Kbuild,
and I would happily take a patch implementing that.
net/tcp_states.h is not movable to include/linux/ and thus to
userspace, it defines things that are present already in existing
userland header files. If you look, <netinet/tcp.h> defines these
state values, as an enumeration. If you need the TCPF_* flag bit
versions, sorry... you'll need to find some other way to get those
into userspace.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists