netdev - Re: [PATCH] net: santize headers for iproute2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071225124323.70e0c772@deepthought>
Date:	Tue, 25 Dec 2007 12:43:23 -0800
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	David Miller <davem@...emloft.net>
Cc:	vgusev@...nvz.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: santize headers for iproute2


> net/tcp_states.h is not movable to include/linux/ and thus to
> userspace, it defines things that are present already in existing
> userland header files.  If you look, <netinet/tcp.h> defines these
> state values, as an enumeration.  If you need the TCPF_* flag bit
> versions, sorry... you'll need to find some other way to get those
> into userspace.

The problem is that iproute ss.c needs linux/tcp.h to get the tcp_info
structure definition but linux/tcp.h has incompatible definitions with netinet/tcp.h. 
I propose that the enum be moved from net/tcp_states.h to linux/tcp.h.

-- 
Stephen Hemminger <stephen.hemminger@...tta.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html