netdev - Re: [PATCH] veth: move veth.h to include/linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071225222335.GA5927@uranus.ravnborg.org>
Date:	Tue, 25 Dec 2007 23:23:35 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Stephen Hemminger <stephen.hemminger@...tta.com>
Cc:	David Miller <davem@...emloft.net>, vgusev@...nvz.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] veth: move veth.h to include/linux

On Tue, Dec 25, 2007 at 12:46:56PM -0800, Stephen Hemminger wrote:
> Move veth.h from net/ to linux/ since it is a user api, and
> add it to user header processing Kbuild.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org>
> 
> --- a/drivers/net/veth.c	2007-12-25 12:30:56.000000000 -0800
> +++ b/drivers/net/veth.c	2007-12-25 12:31:38.000000000 -0800
> @@ -15,7 +15,7 @@
>  
>  #include <net/dst.h>
>  #include <net/xfrm.h>
> -#include <net/veth.h>
> +#include <linux/veth.h>
>  
>  #define DRV_NAME	"veth"
>  #define DRV_VERSION	"1.0"
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ b/include/linux/veth.h	2007-10-16 16:48:20.000000000 -0700
> @@ -0,0 +1,12 @@
> +#ifndef __NET_VETH_H_
> +#define __NET_VETH_H_
> +
> +enum {
> +	VETH_INFO_UNSPEC,
> +	VETH_INFO_PEER,
> +
> +	__VETH_INFO_MAX
> +#define VETH_INFO_MAX	(__VETH_INFO_MAX - 1)
> +};
> +
> +#endif
> --- a/include/net/veth.h	2007-12-25 12:33:49.000000000 -0800
> +++ /dev/null	1970-01-01 00:00:00.000000000 +0000
> @@ -1,12 +0,0 @@
> -#ifndef __NET_VETH_H_
> -#define __NET_VETH_H_
> -
> -enum {
> -	VETH_INFO_UNSPEC,
> -	VETH_INFO_PEER,
> -
> -	__VETH_INFO_MAX
> -#define VETH_INFO_MAX	(__VETH_INFO_MAX - 1)
> -};
> -
> -#endif
> --- a/include/linux/Kbuild	2007-12-25 12:44:59.000000000 -0800
> +++ b/include/linux/Kbuild	2007-12-25 12:45:31.000000000 -0800
> @@ -342,6 +342,7 @@ unifdef-y += unistd.h
>  unifdef-y += usbdevice_fs.h
>  unifdef-y += user.h
>  unifdef-y += utsname.h
> +unifdef-y += veth.h
>  unifdef-y += videodev2.h
>  unifdef-y += videodev.h
>  unifdef-y += virtio_config.h

Someone will argue that you should use header-y +=
because the file has no conditionals removed by unifdef.

My personal opinion is that we should kill header-y and
I had patches to greatly improve all this but they got 
lost by accident and I have not yet redone them.

	Sam


> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html