netdev - Re: [PATCH] via-velocity big-endian support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071225224333.GA21585@electric-eye.fr.zoreil.com>
Date:	Tue, 25 Dec 2007 23:43:33 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Al Viro <viro@....linux.org.uk>
Cc:	netdev@...r.kernel.org, jgarzik@...ox.com
Subject: Re: [PATCH] via-velocity big-endian support

Al Viro <viro@....linux.org.uk> :
[...]
> diff --git a/drivers/net/via-velocity.h b/drivers/net/via-velocity.h
> index aa91796..e0ec5d4 100644
> --- a/drivers/net/via-velocity.h
> +++ b/drivers/net/via-velocity.h
> @@ -196,26 +196,29 @@
>   *	Receive descriptor
>   */
>  
> +#define DESC_OWNER cpu_to_le16(0x8000)
> +

DESC_OWNER does not seem to be used.

[...]
> +enum {
> +	RX_INTEN = __constant_cpu_to_le16(0x8000)
> +};

Can we avoid using cpu_to_leXY here for consistency sake within the driver
(and among different drivers as well) ?

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html