netdev - Re: [PATCH] via-velocity big-endian support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071225225606.GC27894@ZenIV.linux.org.uk>
Date:	Tue, 25 Dec 2007 22:56:06 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	Al Viro <viro@....linux.org.uk>, netdev@...r.kernel.org,
	jgarzik@...ox.com
Subject: Re: [PATCH] via-velocity big-endian support

On Tue, Dec 25, 2007 at 11:43:33PM +0100, Francois Romieu wrote:
> > +#define DESC_OWNER cpu_to_le16(0x8000)
> > +
> 
> DESC_OWNER does not seem to be used.

*nod*
That should be removed.
 
> [...]
> > +enum {
> > +	RX_INTEN = __constant_cpu_to_le16(0x8000)
> > +};
> 
> Can we avoid using cpu_to_leXY here for consistency sake within the driver
> (and among different drivers as well) ?

???

What is the problem with having such constants?  If you mean "could we
use cpu_to_le16() instead of __constant_cpu_to_le16()", the answer's
no - that's one of the very few places where __constant_.... form is
needed (other are case <...>: and initializers for non-auto variables).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html