netdev - Re: [PATCH] via-velocity big-endian support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071225232135.GA22589@electric-eye.fr.zoreil.com>
Date:	Wed, 26 Dec 2007 00:21:35 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	netdev@...r.kernel.org, jgarzik@...ox.com
Subject: Re: [PATCH] via-velocity big-endian support

Al Viro <viro@...IV.linux.org.uk> :
[...]
> > Can we avoid using cpu_to_leXY here for consistency sake within the driver
> > (and among different drivers as well) ?
> 
> ???

I admit that it is a bit late for the Xmas wishlist. Compare it with:

@@ -1409,31 +1409,33 @@ static int velocity_rx_srv(struct velocity_info *vptr, int status)
 
        do {
                struct rx_desc *rd = vptr->rd_ring + rd_curr;
+               u16 rsr;
[...]
+               rsr = le16_to_cpu(rd->rdesc0.RSR);
[...]
-                       if (rd->rdesc0.RSR & RSR_CRC)
+                       if (rsr & RSR_CRC)
                                  ^^^^^^^ this one is #define RSR_CRC 0x0002

-> some descriptor bits are now declared with an explicit endianness
   while others are not (whence "u16 rsr" where "__le16 rsr" whould
   have fit). Both are fine but it would not hurt to stick with one
   convention in a given driver.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html