netdev - Re: [PATCH 2.6.25] compilation fix for drivers/net/wireless/libertas/debugfs.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071227.164516.236177397.davem@davemloft.net>
Date:	Thu, 27 Dec 2007 16:45:16 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	den@...nvz.org
Cc:	devel@...nvz.org, mchan@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH 2.6.25] compilation fix for
 drivers/net/wireless/libertas/debugfs.c

From: "Denis V. Lunev" <den@...nvz.org>
Date: Thu, 27 Dec 2007 13:24:54 +0300

> Compilation fix. MAC_FMT is required for
> drivers/net/wireless/libertas/debugfs.c

Putting this public macro back into a header file just
for one driver's debug handling is just rediculious.

I've checked in the following fix instead, thanks.

commit f7b4d3b86615b95b104ca0a95902ca86373a6548
Author: David S. Miller <davem@...emloft.net>
Date:   Thu Dec 27 16:43:38 2007 -0800

    [LIBERTAS]: Remove last stray user of MAC_FMT.
    
    Reported by Denis V. Lunev
    
    Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/drivers/net/wireless/libertas/debugfs.c b/drivers/net/wireless/libertas/debugfs.c
index 0bda0b5..95dd4ed 100644
--- a/drivers/net/wireless/libertas/debugfs.c
+++ b/drivers/net/wireless/libertas/debugfs.c
@@ -243,7 +243,8 @@ static void libertas_parse_bssid(char *buf, size_t count,
 	if (!hold)
 		return;
 	hold += 6;
-	sscanf(hold, MAC_FMT, mac, mac+1, mac+2, mac+3, mac+4, mac+5);
+	sscanf(hold, "%02x:%02x:%02x:%02x:%02x:%02x",
+	       mac, mac+1, mac+2, mac+3, mac+4, mac+5);
 	memcpy(scan_cfg->bssid, mac, ETH_ALEN);
 }
 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html