netdev - Re: netlink_proto_init and sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071227.164128.142446759.davem@davemloft.net>
Date:	Thu, 27 Dec 2007 16:41:28 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	tavi@...pub.ro
Cc:	netdev@...r.kernel.org
Subject: Re: netlink_proto_init and sock_init

From: Octavian Purdila <tavi@...pub.ro>
Date: Thu, 27 Dec 2007 14:48:56 +0200

> I've noticed that with some exotic build setups (e.g. mingw) 
> netlink_proto_init is called before sock_init and subsequently sock_alloc 
> runs into a NULL sock_mnt. The following patch seems to fix the problem, but 
> I'm not sure if this is the right thing to do, as there are no _initcall_sync 
> calls in the kernel yet. 

This means that net/netlink/ got linked before net/socket.o, which
should never happen.  net/Makefile reads:

obj-$(CONFIG_NET)		:= socket.o core/
 ...
obj-$(CONFIG_NET)		+= ethernet/ 802/ sched/ netlink/

Which ensures that net/socket.o comes before linking in the
net/netlink/built-in.o object file.

Init call ordering is based upon link ordering, so it looks like
mingw is somehow reordering the object files being linked.

There are many other things that can go wrong if the build environment
does this, please find a way to get your mingw build environment to
not do this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html