netdev - [PATCH net-2.6.25] [NEIGH] Remove unused method from include/net/neighbour.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb3ff54b0712280756m45c92c0bhc1298f6b428ac3ed@mail.gmail.com>
Date:	Fri, 28 Dec 2007 17:56:46 +0200
From:	"Rami Rosen" <ramirose@...il.com>
To:	davem@...emloft.net
Cc:	netdev@...r.kernel.org
Subject: [PATCH net-2.6.25] [NEIGH] Remove unused method from include/net/neighbour.h

Hello,
It seems to me that neigh_is_valid() inline method from
include/net/neighbour.h can be removed since it is not used.

Though it can be considered as an API for future use, and
indeed we have neigh_is_connected() method in this same header (which is BTW
used only in one place, drivers/net/cxgb3/l2t.c), we can easily notice
that we don't have
any accessor method to check whether the neighbour is in NUD_IN_TIMER
(not to mention that we don't have methods to check the single neighbour states,
like NUD_REACHABLE or NUD_DELAY or the other ones). So for consistency
I suggest to
consider removing the neigh_is_valid() method.

Regards,
Rami Rosen

http://www.linux-foundation.org/en/Net:Network_Overview

Signed-off-by: Rami Rosen <ramirose@...il.com>

View attachment "patch.txt" of type "text/plain" (471 bytes)