netdev - Re: [PATCH net-2.6.25] [NEIGH] Remove unused method from include/net/neighbour.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071230.232631.199492951.davem@davemloft.net>
Date:	Sun, 30 Dec 2007 23:26:31 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ramirose@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6.25] [NEIGH] Remove unused method from
 include/net/neighbour.h

From: "Rami Rosen" <ramirose@...il.com>
Date: Fri, 28 Dec 2007 17:56:46 +0200

> It seems to me that neigh_is_valid() inline method from
> include/net/neighbour.h can be removed since it is not used.
> 
> Though it can be considered as an API for future use, and
> indeed we have neigh_is_connected() method in this same header (which is BTW
> used only in one place, drivers/net/cxgb3/l2t.c), we can easily notice
> that we don't have
> any accessor method to check whether the neighbour is in NUD_IN_TIMER
> (not to mention that we don't have methods to check the single neighbour states,
> like NUD_REACHABLE or NUD_DELAY or the other ones). So for consistency
> I suggest to
> consider removing the neigh_is_valid() method.
>
> Signed-off-by: Rami Rosen <ramirose@...il.com>

This is a helper function which was used by drivers implementing
support for the old fast routing code which we removed years ago.

So yes we should remove this.

Patch applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html