netdev - Re: [PATCH 3/7]: [NET]: Do not check netif_running() and carrier state in ->poll()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080108.144731.168854521.davem@davemloft.net>
Date:	Tue, 08 Jan 2008 14:47:31 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	Ramkrishna.Vepa@...erion.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 3/7]: [NET]: Do not check netif_running() and carrier
 state in ->poll()

From: "Ramkrishna Vepa" <Ramkrishna.Vepa@...erion.com>
Date: Tue, 8 Jan 2008 13:17:03 -0500

> Dave,
> 
> This change is not required as the macro, is_s2io_card_up() checks for
> an internal state of the adapter and not netif's state. We want to make
> sure that the adapter registers are not accessed when the adapter is
> being brought down.

If the adapter is being brought down, you would have done
a napi_disable() first and therefore never reach this code
path.

The removal is correct, I read how your driver works.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html