netdev - Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1JDBv3-0006J9-00@gondolin.me.apana.org.au>
Date:	Fri, 11 Jan 2008 15:55:01 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	fubar@...ibm.com (Jay Vosburgh)
Cc:	herbert@...dor.apana.org.au, andy@...yhouse.net, olel@....pl,
	netdev@...r.kernel.org, jgarzik@...ox.com, davem@...emloft.net
Subject: Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24

Jay Vosburgh <fubar@...ibm.com> wrote:
>
>        For the case of the bond_set_multicast_list function, changing
> the existing write_lock to a read_lock_bh doesn't affect any calls to

Right that should also resolve the lockdep issue.  So as long as you
guys are sure that this is safe with respect to the rest of the bonding
driver it's fine by me.

BTW you only need read_lock since set_multicast_list always gets called
with BH off.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html