netdev - Re: [IPV4 3/5] fib_trie: dump doesnt use RCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080123.232747.75654058.davem@davemloft.net>
Date:	Wed, 23 Jan 2008 23:27:47 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...ux-foundation.org
Cc:	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [IPV4 3/5] fib_trie: dump doesnt use RCU

From: Stephen Hemminger <shemminger@...ux-foundation.org>
Date: Wed, 23 Jan 2008 22:45:02 -0800

> Yes, I tested, no the assert didn't hit... Actually, the reason I went 
> down this path was
> because I couldn't trigger -EBUSY with concurrent updates.
> 
> P.s: I checked and Quagga handles -EAGAIN, so if you need an error code that
> would be the one to use.

Ok, but see my other email, the -EBUSY block can't be removed.

Even though for any given ->dump() call RTNL is held, it
is dropped before the next ->dump() call on the same
piece of nlk->cb[] state.

So the node for the nlk->cb->args[2] key can go away due
to an intervening table change.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html