netdev - Re: [PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080123.233006.124819204.davem@davemloft.net>
Date:	Wed, 23 Jan 2008 23:30:06 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	andi@...stfloor.org
Cc:	Ramkrishna.Vepa@...erion.com, Sreenivasa.Honnur@...erion.com,
	netdev@...r.kernel.org, jeff@...zik.org, support@...erion.com
Subject: Re: [PATCH 2.6.25 1/1]S2io: Multiqueue network device support
 implementation

From: Andi Kleen <andi@...stfloor.org>
Date: Thu, 24 Jan 2008 08:25:49 +0100

> > have done away with handling tx completion in the interrupt handler, and
> > are instead handling them in the context of the transmit. The slow path,
> > straggling transmit completions will be handled in the timer context.
> 
> Ok -- hopefully you don't have bad corner cases from this when the pipe
> is not fully filled and then causing longer latencies on completion. 
> Old NAPI sometimes suffered from such problems. 

BTW, such a TX completion timer will stall TCP sockets when the TX
queue of the device is partially filled and then sending stops.

TX ring SKB liberation really must be done in a very small finite
amount of time in order to avoid this problem properly.

Deferring it to HZ granular timers doesn't give a quick enough
response, especially at high packet rates.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html