netdev - Re: [PATCH 2.6.24] fib_trie: apply fixes from fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b25c3fa70801252120v1b928b15pd5a4e7bd2934161b@mail.gmail.com>
Date:	Sat, 26 Jan 2008 14:20:27 +0900
From:	"Joonwoo Park" <joonwpark81@...il.com>
To:	"Julian Anastasov" <ja@....bg>
Cc:	"David S. Miller" <davem@...emloft.net>,
	"Robert Olsson" <robert.olsson@...a.slu.se>,
	netdev@...r.kernel.org, "Joonwoo Park" <joonwpark81@...il.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Jarek Poplawski" <jarkao2@...il.com>, schwab@...e.de
Subject: Re: [PATCH 2.6.24] fib_trie: apply fixes from fib_hash

2008/1/26, Joonwoo Park <joonwpark81@...il.com>:
> On Sat, Jan 26, 2008 at 04:40:30AM +0200, Julian Anastasov wrote:
> >
> > Signed-off-by: Julian Anastasov <ja@....bg>
> > ---
> >
> >       Not tested, someone please check the findings
> >
> > --- linux-2.6.24/net/ipv4/fib_trie.c_orig     2008-01-25 10:45:06.000000000 +0200
> > +
> >               if (cfg->fc_nlflags & NLM_F_REPLACE) {
> >                       struct fib_info *fi_drop;
> >                       u8 state;
> >
> > -                     if (fi->fib_treeref > 1)
> > +                     fa = fa_first;
> > +                     if (fa_match && fa != fa_match)
> >                               goto out;
> > -
>
> Isn't it possible to do this (fib_hash too)?
>                        if (fa_match) {
>                                if (fa != fa_match)
Sorry!
                                  if (fa == fa_match)
>                                        return 0;
>                                goto out;
>                        }
>
> Thanks,
> Joonwoo
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html