netdev - Re: [PATCH 2.6.24] fib_trie: apply fixes from fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.58.0801261031300.3854@u.domain.uli>
Date:	Sat, 26 Jan 2008 11:46:43 +0200 (EET)
From:	Julian Anastasov <ja@....bg>
To:	Joonwoo Park <joonwpark81@...il.com>
cc:	"David S. Miller" <davem@...emloft.net>,
	Robert Olsson <robert.olsson@...a.slu.se>,
	netdev@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>,
	Jarek Poplawski <jarkao2@...il.com>, schwab@...e.de
Subject: Re: [PATCH 2.6.24] fib_trie: apply fixes from fib_hash


	Hello,

On Sat, 26 Jan 2008, Joonwoo Park wrote:

> > >       Not tested, someone please check the findings

	news: simple testing of patched fib_trie seems to work

> > > -                     if (fi->fib_treeref > 1)
> > > +                     fa = fa_first;
> > > +                     if (fa_match && fa != fa_match)
> > >                               goto out;
> > > -
> >
> > Isn't it possible to do this (fib_hash too)?
> >                        if (fa_match) {
> >                                if (fa != fa_match)
> Sorry!
>                                   if (fa == fa_match)
> >                                        return 0;
> >                                goto out;
> >                        }

	I see, your idea is to optimize the case when matched
parameters are same. Considering the used fi is same I don't see
any problems. I'll prepare 2nd version of both patches in
next hours.

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html