netdev - Re: [PATCH] xircom_cb should return NETDEV_TX_BUSY when there are no descriptors available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47A79256.2040805@pobox.com>
Date:	Mon, 04 Feb 2008 17:31:50 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Erik Mouw <mouw@...linux.org>
CC:	netdev@...r.kernel.org,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	jamal <hadi@...erus.ca>
Subject: Re: [PATCH] xircom_cb should return NETDEV_TX_BUSY when there are
 no descriptors available

Erik Mouw wrote:
> On Mon, Feb 04, 2008 at 06:56:54PM +0100, Erik Mouw wrote:
>> Changes in other networking paths uncovered a bug in the xircom_cb
>> driver which made the kernel spew lots of the following error messages:
>>
>>   BUG eth1 code -5 qlen 0
>>
>> It turned out that the driver returned -EIO when there was no
>> descriptor available for sending packets. It should return
>> NETDEV_TX_BUSY instead. This was discussed on the netdev list before,
>> see http://thread.gmane.org/gmane.linux.network/84603 .
>>
>> Signed-off-by: Erik Mouw <mouw@...linux.org>
> 
> Forgot to tell: the patch is against 2.6.24 but should apply cleanly to
> the latest git kernel. The xircom_cb driver appears to be orphaned so
> I've send the patch to you.

Yep, that's the right thing to do...

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html