netdev - Re: [PATCH] xircom_cb should return NETDEV_TX_BUSY when there are no descriptors available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47A8ABE3.1000807@pobox.com>
Date:	Tue, 05 Feb 2008 13:33:07 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Erik Mouw <mouw@...linux.org>
CC:	netdev@...r.kernel.org,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	jamal <hadi@...erus.ca>
Subject: Re: [PATCH] xircom_cb should return NETDEV_TX_BUSY when there are
 no	descriptors available

Erik Mouw wrote:
> Hi,
> 
> Changes in other networking paths uncovered a bug in the xircom_cb
> driver which made the kernel spew lots of the following error messages:
> 
>   BUG eth1 code -5 qlen 0
> 
> It turned out that the driver returned -EIO when there was no
> descriptor available for sending packets. It should return
> NETDEV_TX_BUSY instead. This was discussed on the netdev list before,
> see http://thread.gmane.org/gmane.linux.network/84603 .
> 
> Signed-off-by: Erik Mouw <mouw@...linux.org>
> 
> diff --git a/drivers/net/tulip/xircom_cb.c b/drivers/net/tulip/xircom_cb.c
> index 8fc7274..6b93d01 100644
> --- a/drivers/net/tulip/xircom_cb.c
> +++ b/drivers/net/tulip/xircom_cb.c
> @@ -441,7 +441,7 @@ static int xircom_start_xmit(struct sk_buff *skb, struct net_device *dev)
>  	spin_unlock_irqrestore(&card->lock,flags);
>  	trigger_transmit(card);
>  
> -	return -EIO;
> +	return NETDEV_TX_BUSY;
>  }
>  
>  


applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html