netdev - Re: [PATCH 01/24 for-2.6.25] DM9000: Fix endian-ness of data accesses. Patch from: Laurent Pinchart <laurentp@...-semaphore.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47AB1B94.50304@garzik.org>
Date:	Thu, 07 Feb 2008 09:54:12 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Laurent Pinchart <laurentp@...-semaphore.com>
CC:	Ben Dooks <ben-linux@...ff.org>, netdev@...r.kernel.org,
	akpm@...ux-foundation.org, daniel@...aq.de
Subject: Re: [PATCH 01/24 for-2.6.25] DM9000: Fix endian-ness of data accesses.
 Patch from: Laurent Pinchart <laurentp@...-semaphore.com>

Laurent Pinchart wrote:
> On Wednesday 06 February 2008 12:46, Jeff Garzik wrote:
>> two comments:
>>
>> 1) you should be using __le16 type
>>
>> 2) seems like you should do the same for RxStatus, rather than splitting it
> 
> The DM9000 datasheet (or rather the application notes) describes two distinct 
> fields, even though they both contain some kind of status information.

Sure, there are plenty of distinct fields, just like with every chipset. 
  That doesn't mean byte instructions are the best choice.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html