netdev - Re: [PATHCH 1/16] ServerEngines 10Gb NIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080218180051.f1da667c@mailhost.serverengines.com>
Date:	Mon, 18 Feb 2008 10:00:51 -0800
From:	"Subbu Seetharaman" <subbus@...verengines.com>
To:	netdev@...r.kernel.org
Cc:	shemminger@...ux-foundation.org, jacliburn@...lsouth.net,
	sam@...nborg.org
Subject: Re: [PATHCH 1/16]  ServerEngines 10Gb NIC driver

Thanks for all comments.

I had run checkpatch and corrected all errors excepting a 
few errors about some macros and the warning about the 
typedefs.  The mail client I used to send the patch folded
lines at arbitrary points introduced several trailing white 
space.  This was also the reason for one of the patch not 
applying clean.   We will use git to generate the  patches
as suggested.

Our desire to share common code across drivers for other
OSes has been a cause for some ugliness in coding styles.   

I have one question about bit fields. Several of  
headers in the common code are  generated by  
srcgen from f/w source files.  Some of the  structures 
in these headers  have bit fields (with separate definitions 
for little endian and big endian hosts).  Are these un-acceptable 
in Linux driver submissions ?

Thanks.

Subbu
--------------------------------------

From: Stephen Hemminger [mailto:shemminger@...ux-foundation.org]
To: netdev@...r.kernel.org
Sent: Sun, 17 Feb 2008 09:44:45 -0800
Subject: Re: [PATHCH 1/16] ServerEngines 10Gb NIC driver

Do all vendor drivers have to come in with the same mistakes.
Where is the vendor driver ugly school, and how can the Linux
developers teach there?

Run this through checkpatch script or just read some of the
things that a quick scan shows.

<snip> 

___________________________________________________________________________________
This message, together with any attachment(s), contains confidential and proprietary information of
ServerEngines Corporation and is intended only for the designated recipient(s) named above. Any unauthorized
review, printing, retention, copying, disclosure or distribution is strictly prohibited.  If you are not the
intended recipient of this message, please immediately advise the sender by reply email message and
delete all copies of this message and any attachment(s). Thank you.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html