netdev - Re: [PATHCH 1/16] ServerEngines 10Gb NIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080219190212.5f410fed@osprey.hogchain.net>
Date:	Tue, 19 Feb 2008 19:02:12 -0600
From:	Jay Cliburn <jacliburn@...lsouth.net>
To:	"Subbu Seetharaman" <subbus@...verengines.com>
Cc:	netdev@...r.kernel.org, shemminger@...ux-foundation.org,
	sam@...nborg.org, jeff@...zik.org
Subject: Re: [PATHCH 1/16]  ServerEngines 10Gb NIC driver

On Mon, 18 Feb 2008 10:00:51 -0800
"Subbu Seetharaman" <subbus@...verengines.com> wrote:

> I have one question about bit fields. Several of  
> headers in the common code are  generated by  
> srcgen from f/w source files.  Some of the  structures 
> in these headers  have bit fields (with separate definitions 
> for little endian and big endian hosts).  Are these un-acceptable 
> in Linux driver submissions ?

The netdev maintainer, Jeff Garzik (to whom you should submit your
driver), frowns upon the use of bitfields, and for good reason.  See,
for example, 
http://marc.info/?l=linux-kernel&m=118444531031506&w=2 
http://lkml.org/lkml/2005/8/5/361
http://lkml.org/lkml/2006/6/20/470
http://en.wikipedia.org/wiki/Bit_field.

You should avoid them if at all possible.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html