netdev - Re: [PATCH] net/8021q/vlan_dev.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Feb 2008 22:17:27 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	David Miller <davem@...emloft.net>
CC:	joe@...ches.com, bruno@...nktube.com, netdev@...r.kernel.org,
	jgarzik@...ox.com, linux-wireless@...r.kernel.org,
	linville@...driver.com
Subject: Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac

David Miller wrote:
> From: Patrick McHardy <kaber@...sh.net>
> Date: Mon, 18 Feb 2008 16:19:40 +0100
>
>   
>> Joe Perches wrote:
>>     
>>>
>>>> We specifically removed this sort of thing, please don't
>>>> add it back.
>>>>         
>> Why?
>>     
>
> We converted the entire tree over the print_mac(), and since
> the MAC_FMT stuff was therefore no longer used we could
> remove it.
>
> Some references slipped back in somehow, and thus MAC_FMT
> did too.
>
> There is no reason to keep around a global interface for
> _one_ user when that user can use the recommended interface
> just as equally as the rest of the tree which we converted.
>
> This is a pr_debug() statement we're talking about here.
> :-)
>   

The way pr_debug is implemented it still results in two function
calls per packet since the compiler doesn't know that it doesn't
have visible side-effects besides modifying the (unused) buffer.
I confirmed this using codiff.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html