netdev - Re: [PATCH] net/8021q/vlan_dev.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47B9F92F.7060709@trash.net>
Date:	Mon, 18 Feb 2008 22:31:27 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Joe Perches <joe@...ches.com>
CC:	David Miller <davem@...emloft.net>, bruno@...nktube.com,
	netdev@...r.kernel.org, jgarzik@...ox.com,
	linux-wireless@...r.kernel.org, linville@...driver.com
Subject: Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac

Joe Perches wrote:
> On Mon, 2008-02-18 at 16:19 +0100, Patrick McHardy wrote:
>   
>>> @@ -404,11 +405,8 @@ static int vlan_dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
>>>  
>>>  	pr_debug("%s: about to send skb: %p to dev: %s\n",
>>>  		__FUNCTION__, skb, skb->dev->name);
>>> -	pr_debug("  " MAC_FMT " " MAC_FMT " %4hx %4hx %4hx\n",
>>> -		 veth->h_dest[0], veth->h_dest[1], veth->h_dest[2],
>>> -		 veth->h_dest[3], veth->h_dest[4], veth->h_dest[5],
>>> -		 veth->h_source[0], veth->h_source[1], veth->h_source[2],
>>> -		 veth->h_source[3], veth->h_source[4], veth->h_source[5],
>>> +	pr_debug("  %s %s %4hx %4hx %4hx\n",
>>> +		 print_mac(mac, veth->h_dest), print_mac(mac2, veth->h_source),
>>>       
>> This results in print_mac getting called twice per packet even without
>> debugging. Whats the problem with MAC_FMT?
>>     
>
> It's just a consistency thing.
> It identifies code where MAC addresses are used.
>   
> an allyesconfig is a bit smaller (~.1%).
> pr_debug is a noop when not debugging, print_mac is optimized away.
>   

No its not, which I also stated in the commit message that restored
it.

0x0000000060244313 <vlan_dev_hard_start_xmit+433>:      callq  
0x60161dbd <print_mac>
0x0000000060244318 <vlan_dev_hard_start_xmit+438>:      lea    
-0x50(%rbp),%rdi
0x000000006024431c <vlan_dev_hard_start_xmit+442>:      mov    %r15,%rsi
0x000000006024431f <vlan_dev_hard_start_xmit+445>:      callq  
0x60161dbd <print_mac>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html