| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <47C3C420.1060407@openvz.org> Date: Tue, 26 Feb 2008 10:47:44 +0300 From: Pavel Emelyanov <xemul@...nvz.org> To: David Miller <davem@...emloft.net> CC: kaber@...sh.net, netdev@...r.kernel.org, devel@...nvz.org Subject: Re: [PATCH] Don't limit the number of tunnels with generic name explicitly. David Miller wrote: > From: Pavel Emelyanov <xemul@...nvz.org> > Date: Thu, 21 Feb 2008 15:38:16 +0300 > >> Changelog: >> >> Use the added dev_alloc_name() call to create tunnel device name, >> rather than iterate in a hand-made loop with an artificial limit. >> >> Thanks Patrick for noticing this. >> >> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org> > > Applied, but I had to rework this in two places that didn't > apply cleanly. That's because you skipped the first patch titled "Don't create tunnels with '%' in name.", which adds the dev_alloc_name() call and tosses the error paths a bit. Without this first patch, these four drivers become broken :( When user doesn't specify the name, the device's name will be e.g. "tunl%d", but not "tunl0" like he expects. > The ip_gre.c and ipip.c changes remove a "failed" label but > that can't be done in the current tree as there are other > existing references. > Yup :( this code was removed in that first patch... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists