netdev - Re: lockdep trace from rc2.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1204112688.3729.61.camel@johannes.berg>
Date:	Wed, 27 Feb 2008 12:44:47 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Dave Jones <davej@...emonkey.org.uk>
Cc:	netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: lockdep trace from rc2.


> This should be a correct change afaict, unless tulip has more work
> structs than the media work.
> 
> @@ tulip_down
> -	flush_scheduled_work();
> +	cancel_work_sync(&tp->media_work);

Forgot to mention that the latter just makes sure the work won't run
afterwards, while the former also makes sure it has run if it was
scheduled. That might make a difference if this code assumes it will
run, although for tulip it doesn't looks to be the case.

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html