netdev - Re: lockdep trace from rc2.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1204112436.3729.58.camel@johannes.berg>
Date:	Wed, 27 Feb 2008 12:40:36 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	David Miller <davem@...emloft.net>
Cc:	shemminger@...tta.com, davej@...emonkey.org.uk,
	netdev@...r.kernel.org
Subject: Re: lockdep trace from rc2.


> > Correct link: http://kerneltrap.org/mailarchive/linux-kernel/2007/4/11/76312

Also I just posted an explanation in this thread:

http://marc.info/?l=linux-netdev&m=120393645226652&w=2

> When I first looked at Dave's lockdep trace I grepped around and there
> are a bunch of drivers that call flush_scheduled_work like this.
> 
> It seems that the common case is a driver that shares a lot of code
> between the suspend and ->stop paths.  Tulip is just such a case.

Bugger.

> Maybe it could do something similar to the 8139too fix at the above
> URL, but this is quite cumbersome if you ask me.
> 
> Anyways, could someone please work on a fix for this stuff?

I think most of the instances should use cancel_work_sync() instead of
flush_scheduled_work() unless the work absolutely must still run before
suspend/stop/whatever. See bottom of the second link above, but it needs
to be done by someone familiar with the driver.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)