netdev - Re: lockdep trace from rc2.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080226.224010.227576469.davem@davemloft.net>
Date:	Tue, 26 Feb 2008 22:40:10 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	davej@...emonkey.org.uk, netdev@...r.kernel.org
Subject: Re: lockdep trace from rc2.

From: Stephen Hemminger <shemminger@...tta.com>
Date: Tue, 26 Feb 2008 19:54:00 -0800

> > This has come up before in other drivers,
> > you can't call flush_scheduled_work under RTNL.
> 
> Correct link: http://kerneltrap.org/mailarchive/linux-kernel/2007/4/11/76312

Ok.

When I first looked at Dave's lockdep trace I grepped around and there
are a bunch of drivers that call flush_scheduled_work like this.

It seems that the common case is a driver that shares a lot of code
between the suspend and ->stop paths.  Tulip is just such a case.

I can't tell if it's legal to just move the flush_scheduled_work()
call out of tulip_down() and into it's suspend function.  If it
needs this for suspend it probably needs it for ->stop() too.

Maybe it could do something similar to the 8139too fix at the above
URL, but this is quite cumbersome if you ask me.

Anyways, could someone please work on a fix for this stuff?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html