netdev - Re: [PATCH] add pcibios_enable_device() return value check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200802282254.52426.mb@bu3sch.de>
Date:	Thu, 28 Feb 2008 22:54:52 +0100
From:	Michael Buesch <mb@...sch.de>
To:	Yoichi Yuasa <yoichi_yuasa@...peaks.co.jp>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH]  add pcibios_enable_device() return value check

On Thursday 28 February 2008 14:15:38 Yoichi Yuasa wrote:
> This patch has added pcibios_enable_device() return value check.
> 
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@...peaks.co.jp>
> 
> diff -pruN -X /home/yuasa/Memo/dontdiff linux-orig/drivers/ssb/driver_pcicore.c linux/drivers/ssb/driver_pcicore.c
> --- linux-orig/drivers/ssb/driver_pcicore.c	2008-02-26 15:51:13.146734949 +0900
> +++ linux/drivers/ssb/driver_pcicore.c	2008-02-26 15:54:29.257910690 +0900
> @@ -111,7 +111,8 @@ static void __init ssb_fixup_pcibridge(s
>  
>  	/* Enable PCI bridge bus mastering and memory space */
>  	pci_set_master(dev);
> -	pcibios_enable_device(dev, ~0);
> +	if (pcibios_enable_device(dev, ~0) < 0)
> +		return;

I'm not sure if we really want to silently fail here.
Please add this:
		ssb_printk(KERN_ERR "PCI: SSB bridge enable failed\n");

>  	/* Enable PCI bridge BAR1 prefetch and burst */
>  	pci_write_config_dword(dev, SSB_BAR1_CONTROL, 3);

-- 
Greetings Michael.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html