netdev - [PATCH UPDATE] add pcibios_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200802290245.m1T2jkPC014695@po-mbox300.hop.2iij.net>
Date:	Fri, 29 Feb 2008 11:45:46 +0900
From:	Yoichi Yuasa <yoichi_yuasa@...peaks.co.jp>
To:	Michael Buesch <mb@...sch.de>
Cc:	yoichi_yuasa@...peaks.co.jp, netdev@...r.kernel.org
Subject: [PATCH UPDATE]  add pcibios_enable_device() return value check

Hi Michael,

Thank you for your comment.
I updated it.

Yoichi

This patch has added pcibios_enable_device() return value check.

Signed-off-by: Yoichi Yuasa <yoichi_yuasa@...peaks.co.jp>

diff -pruN -X /home/yuasa/Memo/dontdiff linux-orig/drivers/ssb/driver_pcicore.c linux/drivers/ssb/driver_pcicore.c
--- linux-orig/drivers/ssb/driver_pcicore.c	2008-02-29 09:39:39.355620210 +0900
+++ linux/drivers/ssb/driver_pcicore.c	2008-02-29 10:59:18.649231996 +0900
@@ -111,7 +111,10 @@ static void __init ssb_fixup_pcibridge(s
 
 	/* Enable PCI bridge bus mastering and memory space */
 	pci_set_master(dev);
-	pcibios_enable_device(dev, ~0);
+	if (pcibios_enable_device(dev, ~0) < 0) {
+		ssb_printk(KERN_ERR "PCI: SSB bridge enable failed\n");
+		return;
+	}
 
 	/* Enable PCI bridge BAR1 prefetch and burst */
 	pci_write_config_dword(dev, SSB_BAR1_CONTROL, 3);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html